Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

options for strict tests; few enhancements #241

Merged
merged 10 commits into from
Mar 18, 2024
Merged

options for strict tests; few enhancements #241

merged 10 commits into from
Mar 18, 2024

Conversation

pawelru
Copy link
Contributor

@pawelru pawelru commented Jan 24, 2024 •
edited
Loading

@pawelru pawelru marked this pull request as ready for review January 29, 2024 09:39
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 29, 2024 •
edited
Loading

badge

Code Coverage Summary

Filename              Stmts    Miss  Cover    Missing
------------------  -------  ------  -------  -----------------------------------------------------------------------------------
R/AddCardModule.R       144       2  98.61%   165, 202
R/Archiver.R             25       0  100.00%
R/ContentBlock.R         18       2  88.89%   57-63
R/DownloadModule.R      209      49  76.56%   98-104, 147, 179-184, 193-197, 200-204, 212-216, 219-223, 230-234, 237-241, 280-284
R/FileBlock.R            13       0  100.00%
R/NewpageBlock.R          2       0  100.00%
R/PictureBlock.R         30       2  93.33%   20, 118
R/Previewer.R           297      56  81.14%   199, 215, 217-220, 223, 226-234, 348-392
R/RcodeBlock.R           15       0  100.00%
R/Renderer.R            113      37  67.26%   97-112, 216, 224, 233, 235-256
R/ReportCard.R           77       4  94.81%   192, 233, 238, 259
R/Reporter.R             94       1  98.94%   270
R/ResetModule.R          55       0  100.00%
R/SimpleReporter.R       30       0  100.00%
R/TableBlock.R            9       0  100.00%
R/TextBlock.R            13       0  100.00%
R/utils.R               171      80  53.22%   7, 38-97, 99, 102-109, 167, 179-181, 285-294
R/yaml_utils.R           81       2  97.53%   78, 289
R/zzz.R                  14      10  28.57%   2-13, 19
TOTAL                  1410     245  82.62%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 174b1b5

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 29, 2024 •
edited
Loading

Unit Tests Summary

  1 files   18 suites   12s ⏱️
204 tests 204 ✅ 0 💤 0 ❌
346 runs  346 ✅ 0 💤 0 ❌

Results for commit 174b1b5.

♻️ This comment has been updated with latest results.

@pawelru pawelru added the core label Mar 14, 2024
@pawelru pawelru enabled auto-merge (squash) March 14, 2024 16:46
vedhav
vedhav approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@vedhav vedhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏽

@pawelru pawelru merged commit 384f941 into main Mar 18, 2024
24 checks passed
@pawelru pawelru deleted the strict_tests branch March 18, 2024 08:53
donyunardi added a commit that referenced this pull request Mar 19, 2024
@donyunardi
Revert "options for strict tests; few enhancements (#241)"
d957c12 
This reverts commit 384f941.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vedhav vedhav vedhav approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pawelru @vedhav